test: vendor bats helpers instead of git submodules#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the
bats-support/bats-asserttest helpers from git submodules to plain vendored files undertests/helpers/.Why
The submodules used SSH URLs (
git@github.com:bats-core/...), so a fresh or HTTPS clone got emptytests/helpers/dirs and every bats test failed atload test_helperuntil someone rangit submodule update --init. Silent, confusing friction. These libs are tiny, MIT/CC0-licensed, and change ~once a year — the textbook case for vendoring. Clones now just work.What changed
load.bash+src/+LICENSE(dropped the upstream.github/,test/,CHANGELOG,package.json, etc. —load.bashonly sources its ownsrc/). 19 files total..gitmodules; removed the submodule gitlinks..pre-commit-config.yaml: added top-levelexclude: ^tests/helpers/so our hooks never rewrite vendored upstream code (trailing-whitespace tried to).ci-cd.yml: dropped the now-pointlesssubmodules: truefrom the Lint job checkout.Verification
.gitmodules,.git/modules/tests, inner.gitall gone)🤖 Generated with Claude Code